Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594243002: DevTools: Removed references to serviceworker-internals in inspect_ui (Closed)

Created:
6 years, 3 months ago by vkuzkokov
Modified:
6 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Removed references to serviceworker-internals in inspect_ui BUG=none Committed: https://crrev.com/49128996dac812fa390c092171ab86316b6cb47b Cr-Commit-Position: refs/heads/master@{#296380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M chrome/browser/ui/webui/inspect_ui.h View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
vkuzkokov
PTAL
6 years, 3 months ago (2014-09-23 16:11:17 UTC) #3
dgozman
lgtm
6 years, 3 months ago (2014-09-24 09:16:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594243002/1
6 years, 3 months ago (2014-09-24 09:23:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13085)
6 years, 3 months ago (2014-09-24 09:32:50 UTC) #8
pfeldman
lgtm
6 years, 3 months ago (2014-09-24 10:08:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594243002/1
6 years, 3 months ago (2014-09-24 10:15:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 92fde9b5228cf18544768e3e0cbff08faa42948e
6 years, 3 months ago (2014-09-24 10:20:23 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 10:21:07 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/49128996dac812fa390c092171ab86316b6cb47b
Cr-Commit-Position: refs/heads/master@{#296380}

Powered by Google App Engine
This is Rietveld 408576698