Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59423002: drive: Simplify RemoveOperation with ResourceEntry::local_id (Closed)

Created:
7 years, 1 month ago by hashimoto
Modified:
7 years, 1 month ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Simplify RemoveOperation with ResourceEntry::local_id BUG=None TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/browser/chromeos/drive/file_system/remove_operation.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
7 years, 1 month ago (2013-11-05 09:21:56 UTC) #1
kinaba
lgtm
7 years, 1 month ago (2013-11-05 11:51:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/59423002/1
7 years, 1 month ago (2013-11-06 10:43:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220545
7 years, 1 month ago (2013-11-06 14:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/59423002/1
7 years, 1 month ago (2013-11-07 02:45:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=221132
7 years, 1 month ago (2013-11-07 04:42:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/59423002/1
7 years, 1 month ago (2013-11-07 06:53:54 UTC) #7
hashimoto
7 years, 1 month ago (2013-11-07 08:16:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 manually as r233545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698