Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 594213002: Inline exception handling code into PrivateScriptRunner helpers (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Inline exception handling code into PrivateScriptRunner helpers Inline the v8::TryCatch and rethrowExceptionInPrivateScript() call into PrivateScriptRunner's runDOMAttributeGetter(), runDOMAttributeSetter() and runDOMMethod(). This is done to avoid duplicating the code once per actual attribute getter/setter callback or method callback. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182512

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -226 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 2 chunks +72 lines, -47 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 2 chunks +3 lines, -14 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +4 lines, -15 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 3 chunks +6 lines, -21 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 18 chunks +38 lines, -124 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL Nothing important, just something that seemed reasonable to do. (The TryCatch objects showed up ...
6 years, 3 months ago (2014-09-23 15:57:52 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-23 16:21:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594213002/20001
6 years, 3 months ago (2014-09-23 16:31:32 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 18:09:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182512

Powered by Google App Engine
This is Rietveld 408576698