Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594203002: mojo: Add connector to python bindings. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
Chris Masone, sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add connector to python bindings. BUG=416863 R=sdefresne@chromium.org,cmasone@chromium.org Committed: https://crrev.com/396ba0399fa33234f70fa7b8a6bbbc0e554c053a Cr-Commit-Position: refs/heads/master@{#296685}

Patch Set 1 #

Patch Set 2 : Use weakref for callback. #

Total comments: 2

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -0 lines) Patch
M mojo/mojo.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/python/mojo/bindings/messaging.py View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
A mojo/python/tests/messaging_unittest.py View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 3 months ago (2014-09-23 15:01:52 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/594203002/diff/20001/mojo/public/python/mojo/bindings/messaging.py File mojo/public/python/mojo/bindings/messaging.py (right): https://codereview.chromium.org/594203002/diff/20001/mojo/public/python/mojo/bindings/messaging.py#newcode40 mojo/public/python/mojo/bindings/messaging.py:40: A MessageReceiver that can also handle the handle ...
6 years, 2 months ago (2014-09-25 08:35:38 UTC) #2
qsr
https://chromiumcodereview.appspot.com/594203002/diff/20001/mojo/public/python/mojo/bindings/messaging.py File mojo/public/python/mojo/bindings/messaging.py (right): https://chromiumcodereview.appspot.com/594203002/diff/20001/mojo/public/python/mojo/bindings/messaging.py#newcode40 mojo/public/python/mojo/bindings/messaging.py:40: A MessageReceiver that can also handle the handle the ...
6 years, 2 months ago (2014-09-25 09:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594203002/40001
6 years, 2 months ago (2014-09-25 09:05:38 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 16f663167adf814565b77ec34489c2de64bedf85
6 years, 2 months ago (2014-09-25 09:43:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 09:44:10 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/396ba0399fa33234f70fa7b8a6bbbc0e554c053a
Cr-Commit-Position: refs/heads/master@{#296685}

Powered by Google App Engine
This is Rietveld 408576698