Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 594183004: Extend JSBuiltinReducer to cover Math.fround as well. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend JSBuiltinReducer to cover Math.fround as well. R=bmeurer@chromium.org TEST=compiler-unittests/JSBuiltinReducerTest.MathFround Committed: https://code.google.com/p/v8/source/detail?r=24187

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Benedikt. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1 line) Patch
M src/compiler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/graph-unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/graph-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer-unittest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
A test/mjsunit/asm/math-fround.js View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-24 10:45:55 UTC) #1
Benedikt Meurer
LGTM with nit and assuming that there's a system test for this. :-) https://codereview.chromium.org/594183004/diff/1/src/compiler/js-builtin-reducer-unittest.cc File ...
6 years, 3 months ago (2014-09-24 11:37:51 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/594183004/diff/1/src/compiler/js-builtin-reducer-unittest.cc File src/compiler/js-builtin-reducer-unittest.cc (right): https://codereview.chromium.org/594183004/diff/1/src/compiler/js-builtin-reducer-unittest.cc#newcode196 src/compiler/js-builtin-reducer-unittest.cc:196: EXPECT_TRUE(r.Changed()); On 2014/09/24 11:37:51, Benedikt Meurer ...
6 years, 3 months ago (2014-09-24 13:12:25 UTC) #3
Michael Starzinger
Committed patchset #2 (id:20001) manually as 24187 (presubmit successful).
6 years, 3 months ago (2014-09-24 14:55:26 UTC) #4
chunyang.dai
hello. Michael. This test case will fail on turbofan unsupported platform. For example, X87. ( ...
6 years, 2 months ago (2014-09-25 10:00:39 UTC) #5
Michael Starzinger
6 years, 2 months ago (2014-09-25 10:58:26 UTC) #6
Message was sent while issue was closed.
On 2014/09/25 10:00:39, chunyang.dai wrote:
> hello. Michael.
> This test case will fail on turbofan unsupported platform. For example, X87.
> ( linkage.cc::141  UNIMPLEMETED code ).
> 
> Is it possible to disable it for these platform?
> 
> thanks.

Instead of disabling this test I would propose the following fix:
https://codereview.chromium.org/603923002/

Powered by Google App Engine
This is Rietveld 408576698