Restore last used user session after crash

Restore last used user session after crash

Since primary user profile is loaded synchronously its session will always show up first. Once all users profiles have been loaded we'll switch to the session of the user that was active before crash has happened.

BUG=409226
Committed: https://crrev.com/5df7e99907b42603cb0f23e8a87daf49073e2c64
Cr-Commit-Position: refs/heads/master@{#296907}

[Nikita (slow), 2014-09-23 13:31:30]

nkostylev@chromium.org changed reviewers:
+ dpolukhin@chromium.org

[Dmitry Polukhin, 2014-09-24 11:16:17]

lgtm

https://codereview.chromium.org/594163002/diff/1/components/user_manager/user...
File components/user_manager/user_manager_base.cc (right):

https://codereview.chromium.org/594163002/diff/1/components/user_manager/user...
components/user_manager/user_manager_base.cc:102:
registry->RegisterStringPref(kLastActiveUser, std::string());
Could you please clear this field if the user is removed from system.

[Nikita (slow), 2014-09-25 19:51:49]

https://codereview.chromium.org/594163002/diff/1/components/user_manager/user...
File components/user_manager/user_manager_base.cc (right):

https://codereview.chromium.org/594163002/diff/1/components/user_manager/user...
components/user_manager/user_manager_base.cc:102:
registry->RegisterStringPref(kLastActiveUser, std::string());
On 2014/09/24 11:16:17, Dmitry Polukhin wrote:
> Could you please clear this field if the user is removed from system.

Done.

[Nikita (slow), 2014-09-25 19:54:59]

nkostylev@chromium.org changed reviewers:
+ skuhne@chromium.org

[Nikita (slow), 2014-09-25 19:55:00]

+skuhne@ for chrome/browser/profiles/*

I had to delete this unit_test since it is no longer covering this crash
restoration.

I've got existing browser test that covers crash restoration.
I was updating it but there're more complex test setup environment issues that I
have to overcome. Specifically user session restoration happens before main test
case run.

I'd want to have this CL reviewed so that it can get into M39 in time, thanks.
In the meantime I'll come up with a change to have it fully test covered (either
here or in upcomming CL if it will require substantial test env change).

[Mr4D (OOO till 08-26), 2014-09-25 20:12:31]

lgtm. Please address the comment in some way. :)

https://codereview.chromium.org/594163002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/594163002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_manager.cc:1223: void
ProfileManager::UpdateLastUser(Profile* last_active) {
Since this makes no sense on ChromeOS, you might want to #ifdef this, and/or
insert here the ChromeOS specific code, and/or add a comment that this is
currently unused.

[Nikita (slow), 2014-09-26 06:30:53]

https://codereview.chromium.org/594163002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/594163002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_manager.cc:1223: void
ProfileManager::UpdateLastUser(Profile* last_active) {
On 2014/09/25 20:12:30, Mr4D wrote:
> Since this makes no sense on ChromeOS, you might want to #ifdef this, and/or
> insert here the ChromeOS specific code, and/or add a comment that this is
> currently unused.

Done. Added comment in header. On Chrome OS this method is actually called from 
ProfileManager::BrowserListObserver::OnBrowserSetLastActive() but this value is
not ever used.

[Nikita (slow), 2014-09-26 06:39:42]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-09-26 06:40:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594163002/60001

[Nikita (slow), 2014-09-26 06:58:27]

The CQ bit was unchecked by nkostylev@chromium.org

[Nikita (slow), 2014-09-26 07:58:13]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-09-26 07:58:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594163002/80001

[commit-bot: I haz the power, 2014-09-26 09:03:55]

Committed patchset #5 (id:80001) as 7994431380af5da91b3e02ded4264cb21930a49c

[commit-bot: I haz the power, 2014-09-26 09:04:29]

Patchset 5 (id:??) landed as
https://crrev.com/5df7e99907b42603cb0f23e8a87daf49073e2c64
Cr-Commit-Position: refs/heads/master@{#296907}