Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 594133003: Use base::StringPairs where appropriate from src/extensions (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate from src/extensions Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/245433c30a0d2d0641c0ba699cbf6228c4a43e01 Cr-Commit-Position: refs/heads/master@{#296369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/common/permissions/permission_message_util.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Anand Ratn (left samsung)
rockot@chromium.org: Please review changes in src/extensions module
6 years, 3 months ago (2014-09-23 13:38:29 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-23 16:15:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594133003/1
6 years, 3 months ago (2014-09-24 03:11:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594133003/1
6 years, 3 months ago (2014-09-24 08:52:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as b7b45f17fec3318ff82c900a36f7800e04c2a215
6 years, 3 months ago (2014-09-24 09:15:10 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 09:15:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/245433c30a0d2d0641c0ba699cbf6228c4a43e01
Cr-Commit-Position: refs/heads/master@{#296369}

Powered by Google App Engine
This is Rietveld 408576698