Enable to show input mode indicator with keyboard layout only input methods.

Enable to show input mode indicator with keyboard layout only input methods.

This match enables to initialize the input mode indicator when multiple input methods are available.

BUG=315007
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233514

[Seigo Nonaka, 2013-11-06 02:47:08]

lgtm with nits

https://codereview.chromium.org/59413002/diff/20001/chrome/browser/chromeos/i...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/59413002/diff/20001/chrome/browser/chromeos/i...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:229: // Do NOT
call ibus_controller_->Stop(); here to work around a crash issue
This comment makes no sense now.
Please remove this comment and simply call Start() function in
!keyboard_layout_only.

As you know, IBus no longer lives in Chrome OS, so that calling Start() also
does not make sense. Probably necessary for working with old code. So that,
please remove calling Start() if possible.

[Hiro Komatsu, 2013-11-06 03:14:42]

On 2013/11/06 02:47:08, Seigo Nonaka wrote:
> lgtm with nits
> 
>
https://codereview.chromium.org/59413002/diff/20001/chrome/browser/chromeos/i...
> File chrome/browser/chromeos/input_method/input_method_manager_impl.cc
(right):
> 
>
https://codereview.chromium.org/59413002/diff/20001/chrome/browser/chromeos/i...
> chrome/browser/chromeos/input_method/input_method_manager_impl.cc:229: // Do
NOT
> call ibus_controller_->Stop(); here to work around a crash issue
> This comment makes no sense now.
> Please remove this comment and simply call Start() function in
> !keyboard_layout_only.
> 
> As you know, IBus no longer lives in Chrome OS, so that calling Start() also
> does not make sense. Probably necessary for working with old code. So that,
> please remove calling Start() if possible.

Done, committing.

Removal of Start() doesn't look trivial to be done in this patch.
Let's do it in a different patch.

[commit-bot: I haz the power, 2013-11-06 03:28:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/59413002/70001

[commit-bot: I haz the power, 2013-11-06 04:11:23]

Retried try job too often on linux_rel for step(s) check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-07 03:59:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/59413002/70001

[commit-bot: I haz the power, 2013-11-07 06:53:12]

Change committed as 233514