android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 594103002: [aw] Unregister delegates from AwContents.destroy()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 594103002: [aw] Unregister delegates from AwContents.destroy() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index bfd2fff8948974aaa74c03a090afee0c07126753..e47e0cc207cd6fb0fc2948933987a3b97c8cb02b 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -886,6 +886,8 @@ public class AwContents {

nativeOnDetachedFromWindow(mNativeAwContents);

}

+ mWebContentsObserver.detachFromWebContents();

+ mWebContentsObserver = null;

mContentViewCore.destroy();

mContentViewCore = null;

mNativeAwContents = 0;

« no previous file with comments | « no previous file | android_webview/native/aw_contents.cc » ('j') | no next file with comments »