LayoutTests/fast/forms/date-multiple-fields/date-clearButton-click-and-preventDefault-then-mouseCapture_status.html - Issue 594093002: Fix for mouse capture and release on ClearButtonElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/date-multiple-fields/date-clearButton-click-and-preventDefault-then-mouseCapture_status.html

Issue 594093002: Fix for mouse capture and release on ClearButtonElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/forms/date-multiple-fields/date-clearButton-click-and-preventDefault-then-mouseCapture_status-expected.txt » ('j') | Source/core/html/shadow/ClearButtonElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7

	8 <input id="input" type="date" style="font-family:ahem; font-size:16px;">

	9
	Habib Virji 2014/09/26 13:59:12 nit: No need of extra lines. nit: No need of extra lines.
	10 <button id="js-btn-test" type="button"></button>
	Habib Virji 2014/09/26 13:59:12 nit:ditto nit:ditto
	11

	12 <div id="js-test-output" value=""></div>
	Habib Virji 2014/09/26 13:59:13 nit:ditto nit:ditto
	13

	14 <script>

	15 description('Tests, after clicking mouse on clearInputButton of date input type, will release mouse capture in case of preventdefault.');

	16

	17 var input = document.getElementById('input');

	18 input.value = '2345-07-19';

	19 var center = input.offsetHeight / 2;

	20 var spinButtonOffset = 26;

	21 var clearButtonOffset = 45;

	22

	23 var btn = document.getElementById("js-btn-test");
	Habib Virji 2014/09/26 13:59:12 nit: used double quotes, use single quotes nit: used double quotes, use single quotes
	24 var output = document.getElementById("js-test-output");
	Habib Virji 2014/09/26 13:59:12 nit: used double quotes, use single quotes nit: used double quotes, use single quotes
	25

	26 function mouseClickOn(x, y)

	27 {

	28 if (!window.eventSender)

	29 return;

	30 eventSender.mouseMoveTo(x + input.offsetLeft, y + input.offsetTop);

	31 eventSender.mouseDown();

	32 eventSender.mouseUp();

	33 }

	34

	35 btn.addEventListener("click", function () {
	Habib Virji 2014/09/26 13:59:12 nit: Opening braces on next line nit: used double nit: Opening braces on next line nit: used double quotes, use single quotes
	36 output.value = "Clicked";
	Habib Virji 2014/09/26 13:59:12 nit: used double quotes, use single quotes nit: used double quotes, use single quotes
	37 });

	38

	39 document.addEventListener("mouseup", function (evt) {
	Habib Virji 2014/09/26 13:59:13 nit: Opening braces on next line nit: used double nit: Opening braces on next line nit: used double quotes, use single quotes
	40 evt.preventDefault();

	41 });

	42

	43 mouseClickOn(input.offsetWidth - clearButtonOffset/2 - spinButtonOffset, center) ;

	44 shouldBeEqualToString('input.value', '');

	45

	46 var clickEvent = document.createEvent('MouseEvent');

	47 clickEvent.initEvent('click', true, true);

	48 document.getElementById('js-btn-test').dispatchEvent(clickEvent);

	49

	50
	Habib Virji 2014/09/26 13:59:12 nit: extra line nit: extra line
	51 shouldBeEqualToString('output.value', "Clicked");
	Habib Virji 2014/09/26 13:59:12 nit: used double quotes, use single quotes nit: used double quotes, use single quotes
	52

	53 </script>

	54 </body>

	55 </html>

	56
	Habib Virji 2014/09/26 13:59:12 nit:Extra lines nit:Extra lines
	57

	58

	59

OLD	NEW