Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 594043005: Move paint code from RenderImage/RenderVideo into ImagePainter/VideoPainter. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move paint code from RenderImage into ImagePainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182643

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fix. #

Patch Set 4 : Merged #

Total comments: 6

Patch Set 5 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -206 lines) Patch
M Source/core/core.gypi View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
A Source/core/paint/ImagePainter.h View 1 chunk +32 lines, -0 lines 0 comments Download
A Source/core/paint/ImagePainter.cpp View 1 1 chunk +194 lines, -0 lines 0 comments Download
A + Source/core/paint/VideoPainter.h View 1 2 3 4 1 chunk +11 lines, -7 lines 0 comments Download
A Source/core/paint/VideoPainter.cpp View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderImage.h View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 5 chunks +3 lines, -167 lines 0 comments Download
M Source/core/rendering/RenderReplaced.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 2 2 chunks +2 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chrishtr
6 years, 3 months ago (2014-09-23 21:17:55 UTC) #2
Stephen Chennney
Hell merge coming up for me. https://codereview.chromium.org/594043005/diff/60001/Source/core/paint/VideoPainter.h File Source/core/paint/VideoPainter.h (right): https://codereview.chromium.org/594043005/diff/60001/Source/core/paint/VideoPainter.h#newcode20 Source/core/paint/VideoPainter.h:20: void paint(PaintInfo&, const ...
6 years, 3 months ago (2014-09-24 15:08:18 UTC) #4
chrishtr
https://codereview.chromium.org/594043005/diff/60001/Source/core/paint/VideoPainter.h File Source/core/paint/VideoPainter.h (right): https://codereview.chromium.org/594043005/diff/60001/Source/core/paint/VideoPainter.h#newcode20 Source/core/paint/VideoPainter.h:20: void paint(PaintInfo&, const LayoutPoint&); On 2014/09/24 15:08:18, Stephen Chenney ...
6 years, 3 months ago (2014-09-24 16:30:26 UTC) #5
Stephen Chennney
lgtm
6 years, 3 months ago (2014-09-24 17:41:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594043005/80001
6 years, 3 months ago (2014-09-24 22:53:14 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 00:49:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 182643

Powered by Google App Engine
This is Rietveld 408576698