Issue 59403008: telemetry: Add RenderingStatsUnitTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59403008: telemetry: Add RenderingStatsUnitTest. (Closed)

Created:
7 years, 1 month ago by ernstm

Modified:
7 years, 1 month ago

Reviewers:
nduca, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

telemetry: Add RenderingStatsUnitTest. SmoothnessMetricUnitTest mixes testing of TimelineModel, SmoothnessMetric, and RenderingStats. This patch adds a dedicated unit test for RenderingStats only. It creates a TimelineModel directly, without using TraceEventTimelineImporter (which has its own unit test). RenderingStatsUnitTest verifies that RenderingStats extracts the correct events from the model. This patch also fixes a bug in TimelineModel.FindTimelineMarkers uncovered by the new test. SmoothnessMetricUnitTest itself will be refactored in a separate CL. R=nduca@chromium.org, tonyg@chromium.org BUG=314877 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233512

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -17 lines)			Patch
M	tools/perf/metrics/rendering_stats.py	View	1 2	3 chunks	+0 lines, -5 lines	0 comments	Download
A	tools/perf/metrics/rendering_stats_unittest.py	View		1 chunk	+192 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/core/timeline/model.py	View	1 2	1 chunk	+15 lines, -12 lines	0 comments	Download