Issue 59403004: Android: remove device_data.h from browser/device_orientation/

Issue 59403004: Android: remove device_data.h from browser/device_orientation/ (Closed)

Created:
7 years, 1 month ago by timvolodine

Modified:
6 years, 11 months ago

Reviewers:
Michael van Ouwerkerk, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Android: remove device_data.h from browser/device_orientation/ After refactoring there is no need for a separate DeviceData class anymore, so removing it. BUG=261165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244239

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -67 lines)			Patch
M	content/browser/device_orientation/data_fetcher_impl_android.h	View	1 3	4 chunks	+16 lines, -10 lines	0 comments	Download
M	content/browser/device_orientation/data_fetcher_impl_android.cc	View	1 2	6 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/device_orientation/data_fetcher_impl_android_unittest.cc	View	1	2 chunks	+8 lines, -7 lines	0 comments	Download
D	content/browser/device_orientation/device_data.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

timvolodine

On 2013/11/08 14:54:35, Michael van Ouwerkerk wrote: > lgtm, but no bug? Then maybe use ...

7 years, 1 month ago (2013-11-08 14:56:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/59403004/220001

6 years, 11 months ago (2014-01-10 15:05:24 UTC) #6

Message was sent while issue was closed.

Change committed as 244239