Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.h

Issue 594003002: Added unit tests for ChromePermissionMessageProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed up comments/naming Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVIDER_ H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVIDER_ H_
6 #define CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVIDER_ H_ 6 #define CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVIDER_ H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/gtest_prod_util.h" 11 #include "base/gtest_prod_util.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "extensions/common/permissions/permission_message_provider.h" 13 #include "extensions/common/permissions/permission_message_provider.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 16
17 // Tested in two places:
18 // 1. chrome_permission_message_provider_unittest.cc, which is a regular unit
19 // test for this class
20 // 2. chrome/browser/extensions/permission_messages_unittest.cc, which is an
21 // integration test that ensures messages are correctly generated for
22 // extensions created through the extension system.
17 class ChromePermissionMessageProvider : public PermissionMessageProvider { 23 class ChromePermissionMessageProvider : public PermissionMessageProvider {
18 public: 24 public:
19 ChromePermissionMessageProvider(); 25 ChromePermissionMessageProvider();
20 virtual ~ChromePermissionMessageProvider(); 26 virtual ~ChromePermissionMessageProvider();
21 27
22 // PermissionMessageProvider implementation. 28 // PermissionMessageProvider implementation.
23 virtual PermissionMessages GetPermissionMessages( 29 virtual PermissionMessages GetPermissionMessages(
24 const PermissionSet* permissions, 30 const PermissionSet* permissions,
25 Manifest::Type extension_type) const OVERRIDE; 31 Manifest::Type extension_type) const OVERRIDE;
26 virtual std::vector<base::string16> GetWarningMessages( 32 virtual std::vector<base::string16> GetWarningMessages(
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 const PermissionSet* old_permissions, 72 const PermissionSet* old_permissions,
67 const PermissionSet* new_permissions, 73 const PermissionSet* new_permissions,
68 Manifest::Type extension_type) const; 74 Manifest::Type extension_type) const;
69 75
70 DISALLOW_COPY_AND_ASSIGN(ChromePermissionMessageProvider); 76 DISALLOW_COPY_AND_ASSIGN(ChromePermissionMessageProvider);
71 }; 77 };
72 78
73 } // namespace extensions 79 } // namespace extensions
74 80
75 #endif // CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVID ER_H_ 81 #endif // CHROME_COMMON_EXTENSIONS_PERMISSIONS_CHROME_PERMISSION_MESSAGE_PROVID ER_H_
OLDNEW
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698