Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: Source/core/rendering/RenderLayerModelObject.cpp

Issue 593873002: Alternate way to track first paint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Adjust setShouldDoFullPaintInvalidationWithReason API Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerModelObject.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerModelObject.cpp
diff --git a/Source/core/rendering/RenderLayerModelObject.cpp b/Source/core/rendering/RenderLayerModelObject.cpp
index fbb615ef15259e005588f409c5e7aa85e6cfa8d3..9abd004c0c009a54c8e31f1ed20da6f8982b22ed 100644
--- a/Source/core/rendering/RenderLayerModelObject.cpp
+++ b/Source/core/rendering/RenderLayerModelObject.cpp
@@ -192,17 +192,13 @@ void RenderLayerModelObject::invalidateTreeIfNeeded(const PaintInvalidationState
invalidatePaintOfSubtreesIfNeeded(childTreeWalkState);
}
-void RenderLayerModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRect& r) const
+void RenderLayerModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRect& r, InvalidationReason invalidationReason) const
{
// https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
// so assert but check that the layer is composited.
ASSERT(compositingState() != NotComposited);
- WebInvalidationDebugAnnotations annotations = WebInvalidationDebugAnnotationsNone;
- if (!hadPaintInvalidation())
- annotations = WebInvalidationDebugAnnotationsFirstPaint;
- // FIXME: The callers assume they are calling a const function but this function has a side effect.
- const_cast<RenderLayerModelObject*>(this)->setHadPaintInvalidation();
+ WebInvalidationDebugAnnotations annotations = invalidationReason == InvalidationRendererInsertion ? WebInvalidationDebugAnnotationsFirstPaint : WebInvalidationDebugAnnotationsNone;
// FIXME: generalize accessors to backing GraphicsLayers so that this code is squashing-agnostic.
if (layer()->groupedMapping()) {
« no previous file with comments | « Source/core/rendering/RenderLayerModelObject.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698