Factor common code into native_viewport_controller.cc

mojo/services/native_viewport/native_viewport.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_H_
 #define MOJO_SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_H_
 
 #include "base/memory/scoped_ptr.h"
-
-namespace gfx {
-class Size;
-}
+#include "ui/gfx/native_widget_types.h"
+#include "ui/gfx/rect.h"
 
 namespace gpu {
+class GLInProcessContext;
 namespace gles2 {
 class GLES2Interface;
 }
 }
 
 namespace ui {
 class Event;
 }
 
 namespace mojo {
@@ skipping 10 matching lines @@
   virtual bool OnEvent(ui::Event* event) = 0;
   virtual void OnDestroyed() = 0;
   virtual void OnGLContextAvailable(gpu::gles2::GLES2Interface* gl) = 0;
   virtual void OnGLContextLost() = 0;
   virtual void OnResized(const gfx::Size& size) = 0;
 };
 
 // Encapsulation of platform-specific Viewport.
 class NativeViewport {
  public:
-  virtual ~NativeViewport() {}
+  virtual ~NativeViewport();
 
   virtual void Close() = 0;
 
   static scoped_ptr<NativeViewport> Create(shell::Context* context,
                                            NativeViewportDelegate* delegate);
+
+ protected:
+  explicit NativeViewport(NativeViewportDelegate* delegate);
+
+  void OnAcceleratedWidgetAvailable();

[Ben Goodger (Google), 2013/11/06 07:17:17]

wdyt about this stuff being the responsibility of this object's delegate instead
of making this type concrete?

[abarth-chromium, 2013/11/06 15:40:55]

It depends on whether we're going to have the object's delegate be a concrete
CPP class or whether the delegate is going to be remote over IPC.  I was
imagining that NativeViewport and NativeViewportDelegate would actually be the
IPC end points, which would mean it was NativeViewport's object to instantiate
the command buffer.

+  void OnGLContextLost();
+
+  NativeViewportDelegate* delegate_;
+  gfx::Rect bounds_;
+  gfx::AcceleratedWidget widget_;
+  scoped_ptr<gpu::GLInProcessContext> gl_context_;
 };
 
 }  // namespace services
 }  // namespace mojo
 
 #endif  // MOJO_SERVICES_NATIVE_VIEWPORT_NATIVE_VIEWPORT_H_