Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 59383006: Delete gpu/command_buffer/client/atomicops.h (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Delete gpu/command_buffer/client/atomicops.h command_buffer was historically included in nacl-compiled things, and base wasn't. These days, base is included in nacl-compiled things too, so the duplication can be removed. BUG=none R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233171

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -163 lines) Patch
D gpu/command_buffer/client/atomicops.h View 1 chunk +0 lines, -49 lines 0 comments Download
D gpu/command_buffer/client/atomicops.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/share_group.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer_client.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
(This goes on top of https://codereview.chromium.org/58913003/ )
7 years, 1 month ago (2013-11-05 16:05:15 UTC) #1
piman
lgtm
7 years, 1 month ago (2013-11-05 19:46:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/59383006/50001
7 years, 1 month ago (2013-11-05 22:21:05 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on linux_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-05 23:14:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/59383006/230002
7 years, 1 month ago (2013-11-05 23:18:41 UTC) #5
Nico
7 years, 1 month ago (2013-11-06 01:12:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r233171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698