Issue 59383002: Remove TreatNullAs=NullString for HTMLAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59383002: Remove TreatNullAs=NullString for HTMLAreaElement (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), Inactive

CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@nullanchor

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for HTMLAreaElement http://whatwg.org/html#htmlareaelement The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects ping as a URL property, which is not per spec. IE11 reflects coords as '0,0,0,0' and shape as 'rect', while it doesn't support ping. Presto doesn't support ping. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161340

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -17 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/ping-attribute-dom-binding.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLAreaElement.idl	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/59383002/1

7 years, 1 month ago (2013-11-05 14:27:29 UTC) #4

Message was sent while issue was closed.

Change committed as 161340

Expand Messages | Collapse Messages