Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 59373003: AllocationProfiler: introduce allocation_profiler flag in V8 api. (Closed)

Created:
7 years, 1 month ago by loislo
Modified:
7 years, 1 month ago
Reviewers:
alph, yurys, danno
CC:
v8-dev, yurys, alph, Paweł Hajdan Jr.
Visibility:
Public.

Description

AllocationProfiler: introduce allocation_profiler flag in V8 api. Allocation profiler needs to instrument code in stubs, biltins etc. It is a bit tricky thing due to complex structure of v8 heap. The simplest solution is to create isolate without snapshot. So I introduced allocation_profiler flag and corresponding api methods. static bool EnableAllocationProfiler(Isolate* isolate); static bool IsAllocationProfilerEnabled(Isolate* isolate); BUG= Mixed with patch from issue 43693002 by yurys. Drive by fix: do not count untracked objects twice.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -61 lines) Patch
M include/v8.h View 1 chunk +18 lines, -0 lines 1 comment Download
M src/allocation-tracker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +20 lines, -3 lines 0 comments Download
M src/code-stubs.h View 2 chunks +23 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/frames.h View 5 chunks +9 lines, -5 lines 0 comments Download
M src/frames.cc View 4 chunks +14 lines, -9 lines 0 comments Download
M src/frames-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/isolate.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +18 lines, -36 lines 1 comment Download
M test/cctest/test-heap-profiler.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
loislo
7 years, 1 month ago (2013-11-05 13:34:07 UTC) #1
alph
https://codereview.chromium.org/59373003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/59373003/diff/1/include/v8.h#newcode4605 include/v8.h:4605: */ static bool IsAllocationProfilerEnabled(Isolate* isolate); nit: a new line ...
7 years, 1 month ago (2013-11-05 13:55:20 UTC) #2
danno
7 years, 1 month ago (2013-11-05 14:23:26 UTC) #3
NOT LGTM. This feature requires some fundamental design follow-up before any
more patches land related to it, this is a patch of a patch of a patch of a
implementation that needs to be re-thought through at a high-level again. I will
be discussing separately with Yury how to proceed later this afternoon.

Powered by Google App Engine
This is Rietveld 408576698