Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 593703002: Revert of DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328 (Closed)

Created:
6 years, 3 months ago by caseq
Modified:
6 years, 3 months ago
Reviewers:
apavlov, dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328 (patchset #1 id:1 of https://codereview.chromium.org/593673002/) Reason for revert: Broke the following tests: inspector/initial-modules-load.html inspector/open-with-rendering-option-enabled.html Original issue's description: > DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328 > > R=dgozman,lushnikov > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182405 TBR=dgozman@chromium.org,lushnikov@chromium.org,apavlov@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M Source/devtools/front_end/Runtime.js View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caseq
Created Revert of DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328
6 years, 3 months ago (2014-09-22 11:33:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593703002/1
6 years, 3 months ago (2014-09-22 11:33:51 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 11:34:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182409

Powered by Google App Engine
This is Rietveld 408576698