Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 593683004: Revert of Enable ASan default options on Mac. (Closed)

Created:
6 years, 3 months ago by Alexander Potapenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable ASan default options on Mac. (patchset #4 id:60001 of https://codereview.chromium.org/581983003/) Reason for revert: This CL broke ui_unittests on both Mac ASan and Mac ASan 64 bots: /Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests --brave-new-test-launcher --test-launcher-bot-mode --verbose --test-launcher-print-test-stdio=always --gtest_print_time --test-launcher-summary-output=/tmp/tmpnPVxX8 dyld: Library not loaded: @executable_path/../Versions/1.0.0.0/ui_unittests Framework.framework/ui_unittests Framework Referenced from: /Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests Reason: image not found http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/5393/steps/ui_unittests/logs/stdio Original issue's description: > Enable ASan default options on Mac. > > This CL links libsanitizer_options into every executable built with ASan on OSX. > The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc > > Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds. > > BUG=302040 > R=cpu@chromium.org > > Committed: https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955 > Cr-Commit-Position: refs/heads/master@{#295958} TBR=cpu@chromium.org,earthdok@chromium.org NOTREECHECKS=true NOTRY=true BUG=302040 Committed: https://crrev.com/5ed6fe035890a10288da3b99b2b46a7680b4636f Cr-Commit-Position: refs/heads/master@{#295987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -41 lines) Patch
M build/common.gypi View 4 chunks +9 lines, -10 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M build/sanitizers/sanitizers.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/app/chrome_exe_main_mac.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/app/framework.order View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Enable ASan default options on Mac.
6 years, 3 months ago (2014-09-22 16:31:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593683004/1
6 years, 3 months ago (2014-09-22 16:32:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4ab1ad60316248fd1cdf7ef72e46ec6bfdd6084e
6 years, 3 months ago (2014-09-22 16:34:58 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:35:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ed6fe035890a10288da3b99b2b46a7680b4636f
Cr-Commit-Position: refs/heads/master@{#295987}

Powered by Google App Engine
This is Rietveld 408576698