Issue 593673002: DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 593673002: DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328 (Closed)

Created:
6 years, 3 months ago by apavlov

Modified:
6 years, 3 months ago

Reviewers:
dgozman, lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328 R=dgozman,lushnikov NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182405

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	Source/devtools/front_end/Runtime.js	View		3 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593673002/1

6 years, 3 months ago (2014-09-22 10:22:54 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 182405

6 years, 3 months ago (2014-09-22 10:23:35 UTC) #5

caseq

6 years, 3 months ago (2014-09-22 11:33:23 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/593703002/ by caseq@chromium.org.

The reason for reverting is: Broke the following tests:
inspector/initial-modules-load.html
inspector/open-with-rendering-option-enabled.html.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages