Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 593583004: Add MinidumpContext (X86 and AMD64 variants) and their writers (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpContext (X86 and AMD64 variants) and their writers. These are fairly simple classes and it’s not valuable to test them individually. They will be tested as part of MinidumpThreadWriter and MinidumpExceptionWriter. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/cb2288d1748c7cb51f0c934b51714e7b6d387967

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -0 lines) Patch
M minidump/minidump.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A minidump/minidump_context.h View 1 1 chunk +363 lines, -0 lines 0 comments Download
A minidump/minidump_context_writer.h View 1 1 chunk +115 lines, -0 lines 0 comments Download
A minidump/minidump_context_writer.cc View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 19:53:34 UTC) #2
Robert Sesek
https://codereview.chromium.org/593583004/diff/1/minidump/minidump_context.h File minidump/minidump_context.h (right): https://codereview.chromium.org/593583004/diff/1/minidump/minidump_context.h#newcode30 minidump/minidump_context.h:30: //! \brief `CONTEXT_SERVICE_ACTIVE`. Am I supposed to know what ...
6 years, 2 months ago (2014-09-24 15:42:15 UTC) #3
Mark Mentovai
I didn’t know what those architecture-independent CONTEXT_* things were about either, because they weren’t really ...
6 years, 2 months ago (2014-09-24 16:58:28 UTC) #4
Robert Sesek
LGTM
6 years, 2 months ago (2014-09-24 17:22:03 UTC) #5
Mark Mentovai
6 years, 2 months ago (2014-09-24 17:34:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as cb2288d1748c (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698