Issue 593583002: Assert that frame() derefs a non-null pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 593583002: Assert that frame() derefs a non-null pointer. (Closed)

Created:
6 years, 3 months ago by sof

Modified:
6 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, groby+blinkspell_chromium.org, oilpan-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Assert that frame() derefs a non-null pointer. The Frame references kept by these objects are assumed to be non-null; assert that it is so. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182394

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -8 lines)			Patch
M	Source/core/editing/Editor.h	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	Source/core/editing/InputMethodController.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/editing/SpellCheckRequester.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/editing/SpellChecker.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameConsole.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameView.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	Source/core/frame/RemoteFrameView.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/testing/DummyPageHolder.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593583002/1

6 years, 3 months ago (2014-09-22 06:22:11 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 07:26:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182394