Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 593573003: Populate volume items without resolving their display roots. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 2 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Populate volume items without resolving their display roots. * Populate volumes without resolving their display root. The display root will be resolved after decorate() of the volume item. If failed, the display root will be tried to be resolved when the volume item is activated (by click/Ctrl+N/etc...). * Remove DirectoryTree.models_, which was a temporary variable to keep resolved display roots. BUG=413317 TEST=manually tested the case when the first resolveDisplayRoot() fails. run browser_tests. Committed: https://crrev.com/eb2869eb1fda71b797b4834c7a75a511eb50a574 Cr-Commit-Position: refs/heads/master@{#296885}

Patch Set 1 #

Patch Set 2 : Update Drive's children when the Drive is clicked. #

Patch Set 3 : Rebase and update browser_tests. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -61 lines) Patch
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/folder_shortcuts.js View 1 2 1 chunk +1 line, -1 line 1 comment Download
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 11 chunks +38 lines, -60 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
Tomasz, could you take a look? Thanks! https://codereview.chromium.org/593573003/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/folder_shortcuts.js File chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/folder_shortcuts.js (right): https://codereview.chromium.org/593573003/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/folder_shortcuts.js#newcode45 chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/folder_shortcuts.js:45: navItem: '#tree-item-autogen-id-2', ...
6 years, 2 months ago (2014-09-25 06:15:42 UTC) #2
mtomasz
Basically looks good, but I'll take a deeper look tomorrow. Thanks for fixing!
6 years, 2 months ago (2014-09-25 09:28:30 UTC) #3
mtomasz
lgtm
6 years, 2 months ago (2014-09-26 02:35:41 UTC) #4
fukino
On 2014/09/26 02:35:41, mtomasz wrote: > lgtm Thanks!
6 years, 2 months ago (2014-09-26 02:38:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593573003/40001
6 years, 2 months ago (2014-09-26 02:39:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4496259415bf236e11780054c33001701db66fcb
6 years, 2 months ago (2014-09-26 04:46:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 04:47:24 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb2869eb1fda71b797b4834c7a75a511eb50a574
Cr-Commit-Position: refs/heads/master@{#296885}

Powered by Google App Engine
This is Rietveld 408576698