Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 593573002: Add missing linux-libc-dev:i386 package to arm_list (Closed)

Created:
6 years, 3 months ago by Wei-Ning Huang
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing linux-libc-dev:i386 package to arm_list BUG=chromium:410129 TEST=remove linux-libc-dev:i386 then run ninja -> fails TEST=install linux-libc-dev:i386 then run ninja -> works Committed: https://crrev.com/34687555d4f325291d0c660dda2f6970f8df5b9a Cr-Commit-Position: refs/heads/master@{#296231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Sam Clegg
Did you make sure this works on trusty as well as precise? If so than ...
6 years, 3 months ago (2014-09-22 17:28:19 UTC) #2
Wei-Ning Huang
On 2014/09/22 17:28:19, Sam Clegg wrote: > Did you make sure this works on trusty ...
6 years, 3 months ago (2014-09-23 13:35:09 UTC) #3
Sam Clegg
On 2014/09/23 13:35:09, Wei-Ning Huang wrote: > On 2014/09/22 17:28:19, Sam Clegg wrote: > > ...
6 years, 3 months ago (2014-09-23 16:34:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593573002/1
6 years, 3 months ago (2014-09-23 17:59:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4d362eccf9e1d96f40459b59995081eef51278c6
6 years, 3 months ago (2014-09-23 20:56:12 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 20:56:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34687555d4f325291d0c660dda2f6970f8df5b9a
Cr-Commit-Position: refs/heads/master@{#296231}

Powered by Google App Engine
This is Rietveld 408576698