content/browser/media/capture/web_contents_video_capture_device.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary headers. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/capture/web_contents_video_capture_device.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device.cc b/content/browser/media/capture/web_contents_video_capture_device.cc

index 3bd7906b18b3730fca3ecc1305b144f80f3cc7a3..c3818e364c3031b54323233bda520d6b8748231d 100644

--- a/content/browser/media/capture/web_contents_video_capture_device.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device.cc

@@ -259,7 +259,8 @@ class WebContentsCaptureMachine : public VideoCaptureMachine {

const RenderWidgetHostViewFrameSubscriber::DeliverFrameCallback&

deliver_frame_cb,

bool success,

- const SkBitmap& bitmap);

+ const SkBitmap& bitmap,

+ const int& response);

// Response callback for RWHVP::CopyFromCompositingSurfaceToVideoFrame().

void DidCopyFromCompositingSurfaceToVideoFrame(

@@ -689,7 +690,8 @@ void WebContentsCaptureMachine::DidCopyFromBackingStore(

const RenderWidgetHostViewFrameSubscriber::DeliverFrameCallback&

deliver_frame_cb,

bool success,

- const SkBitmap& bitmap) {

+ const SkBitmap& bitmap,

+ const int& response) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

base::TimeTicks now = base::TimeTicks::Now();