Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary headers. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index cecca6de166bdef20bd3fb02d0282830af6e9146..e13ed8eed47e6a531e26bbe4f2972cdf33a9fcb9 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -27,6 +27,7 @@
#include "base/values.h"
#include "content/common/edit_command.h"
#include "content/common/input/input_event_ack_state.h"
+#include "content/common/readback_types.h"
#include "content/public/browser/browser_plugin_guest_delegate.h"
#include "content/public/browser/web_contents_observer.h"
#include "third_party/WebKit/public/web/WebCompositionUnderline.h"
@@ -143,10 +144,9 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
void UpdateVisibility();
- void CopyFromCompositingSurface(
- gfx::Rect src_subrect,
- gfx::Size dst_size,
- const base::Callback<void(bool, const SkBitmap&)>& callback);
+ void CopyFromCompositingSurface(gfx::Rect src_subrect,
+ gfx::Size dst_size,
+ CopyFromCompositingSurfaceCallback& callback);
BrowserPluginGuestManager* GetBrowserPluginGuestManager() const;
@@ -342,8 +342,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// Each copy-request is identified by a unique number. The unique number is
// used to keep track of the right callback.
int copy_request_id_;
- typedef base::Callback<void(bool, const SkBitmap&)> CopyRequestCallback;
- typedef std::map<int, const CopyRequestCallback> CopyRequestMap;
+ typedef std::map<int, const CopyFromCompositingSurfaceCallback>
+ CopyRequestMap;
CopyRequestMap copy_request_callbacks_;
// Indicates that this BrowserPluginGuest has associated renderer-side state.

Powered by Google App Engine
This is Rietveld 408576698