Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 37f3648fcac218e3ba43790eb914a7480c49bfd7..ce28b95312f694805f1d22d8e873c689b37f9a15 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -948,7 +948,7 @@ void RenderWidgetHostViewAura::SelectionBoundsChanged(
void RenderWidgetHostViewAura::CopyFromCompositingSurface(
const gfx::Rect& src_subrect,
const gfx::Size& dst_size,
- CopyFromCompositingSurfaceCallback& callback,
+ ReadbackRequestCallback& callback,
const SkColorType color_type) {
delegated_frame_host_->CopyFromCompositingSurface(
src_subrect, dst_size, callback, color_type);
@@ -1260,9 +1260,10 @@ void RenderWidgetHostViewAura::ShowDisambiguationPopup(
}
void RenderWidgetHostViewAura::DisambiguationPopupRendered(
- bool success,
- const SkBitmap& result) {
- if (!success || disambiguation_scroll_offset_ != last_scroll_offset_)
+ const SkBitmap& result,
+ ReadbackResponse response) {
+ if ((response != READBACK_SUCCESS) ||
+ disambiguation_scroll_offset_ != last_scroll_offset_)
return;
// Use RenderViewHostDelegate to get to the WebContentsViewAura, which will

Powered by Google App Engine
This is Rietveld 408576698