content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index ab1bff89c8190f2157608257269ccc371f974589..c6ad5390ffb216f9baf87ee21780ae7436ca0b49 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -271,9 +271,9 @@ bool RenderWidgetHostViewChildFrame::PostProcessEventForPluginIme(

void RenderWidgetHostViewChildFrame::CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& /* dst_size */,

- CopyFromCompositingSurfaceCallback& callback,

+ ReadbackRequestCallback& callback,

const SkColorType color_type) {

- callback.Run(false, SkBitmap());

+ callback.Run(SkBitmap(), READBACK_NOT_SUPPORTED);

}

void RenderWidgetHostViewChildFrame::CopyFromCompositingSurfaceToVideoFrame(