content/browser/devtools/protocol/color_picker.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/color_picker.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/color_picker.cc

diff --git a/content/browser/devtools/protocol/color_picker.cc b/content/browser/devtools/protocol/color_picker.cc

index dec4f3103b335a3f355d60032d2abb678c00fed2..44f72106ece7308313ccbfe7b583c9b270f6961f 100644

--- a/content/browser/devtools/protocol/color_picker.cc

+++ b/content/browser/devtools/protocol/color_picker.cc

@@ -95,11 +95,12 @@ void ColorPicker::ResetFrame() {

last_cursor_y_ = -1;

}

-void ColorPicker::FrameUpdated(bool succeeded, const SkBitmap& bitmap) {

+void ColorPicker::FrameUpdated(const SkBitmap& bitmap,

+ ReadbackResponse response) {

if (!enabled_)

return;

- if (succeeded) {

+ if (response == READBACK_SUCCESS) {

frame_ = bitmap;

UpdateCursor();

}