content/browser/android/content_readback_handler.h - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_readback_handler.h

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_readback_handler.h

diff --git a/content/browser/android/content_readback_handler.h b/content/browser/android/content_readback_handler.h

index 403bdd0a7af20e7661f2aa13224a9c66d3607343..66b2c8588d4fcaea36e4fb19d9a4892bd07ac662 100644

--- a/content/browser/android/content_readback_handler.h

+++ b/content/browser/android/content_readback_handler.h

@@ -10,6 +10,7 @@

#include "base/android/jni_weak_ref.h"

#include "base/callback.h"

#include "base/memory/weak_ptr.h"

+#include "content/public/browser/readback_types.h"

class SkBitmap;

@@ -48,8 +49,8 @@ class ContentReadbackHandler {

virtual ~ContentReadbackHandler();

void OnFinishReadback(int readback_id,

- bool success,

- const SkBitmap& bitmap);

+ const SkBitmap& bitmap,

+ ReadbackResponse response);

base::android::ScopedJavaGlobalRef<jobject> java_obj_;

base::WeakPtrFactory<ContentReadbackHandler> weak_factory_;