Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use content namespace to resolve readback params. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/pdf/pdf_browsertest_base.cc ('K') | « content/browser/devtools/protocol/color_picker.cc ('k') | content/browser/devtools/protocol/page_handler.cc » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index fe01ece07941b0eee5a3b3b5413ec403d28d34ab..fe014f6d6d892561688e8d2c90f8f7961d73767f 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -11,6 +11,7 @@
#include "base/time/time.h"
#include "cc/output/compositor_frame_metadata.h"
#include "content/browser/devtools/protocol/devtools_protocol_handler_impl.h"
+#include "content/public/browser/readback_types.h"
class SkBitmap;
@@ -85,12 +86,11 @@ class PageHandler {
void NotifyScreencastVisibility(bool visible);
void InnerSwapCompositorFrame();
- void ScreencastFrameCaptured(
- const std::string& format,
- int quality,
- const cc::CompositorFrameMetadata& metadata,
- bool success,
- const SkBitmap& bitmap);
+ void ScreencastFrameCaptured(const std::string& format,
+ int quality,
+ const cc::CompositorFrameMetadata& metadata,
+ const SkBitmap& bitmap,
+ const ReadbackResponse& response);
void ScreenshotCaptured(
scoped_refptr<DevToolsProtocol::Command> command,
« chrome/browser/ui/pdf/pdf_browsertest_base.cc ('K') | « content/browser/devtools/protocol/color_picker.cc ('k') | content/browser/devtools/protocol/page_handler.cc » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698