Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest_base.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use content namespace to resolve readback params. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/pdf/pdf_browsertest_base.cc
diff --git a/chrome/browser/ui/pdf/pdf_browsertest_base.cc b/chrome/browser/ui/pdf/pdf_browsertest_base.cc
index 9420537f9a8fe76837d0fb46be9c183f664d858a..ad7d81d13f1b2a2e635d5380fefa009f638aae0f 100644
--- a/chrome/browser/ui/pdf/pdf_browsertest_base.cc
+++ b/chrome/browser/ui/pdf/pdf_browsertest_base.cc
@@ -111,10 +111,11 @@ bool PDFBrowserTest::VerifySnapshot(const std::string& expected_filename) {
return !snapshot_different_;
}
-void PDFBrowserTest::CopyFromBackingStoreCallback(bool success,
- const SkBitmap& bitmap) {
+void PDFBrowserTest::CopyFromBackingStoreCallback(
+ const SkBitmap& bitmap,
+ const content::ReadbackResponse& response) {
base::MessageLoopForUI::current()->Quit();
- ASSERT_EQ(success, true);
+ ASSERT_EQ((response == content::READBACK_SUCCESS), true);
piman 2014/11/07 01:55:42 nit: ASSERT_EQ(response, content::READBACK_SUCCESS
sivag 2014/11/07 12:27:41 Done.
base::FilePath reference = ui_test_utils::GetTestFilePath(
base::FilePath(FILE_PATH_LITERAL("pdf_private")),
base::FilePath().AppendASCII(expected_filename_));

Powered by Google App Engine
This is Rietveld 408576698