Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/ui/pdf/pdf_browsertest_base.h

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_ 5 #ifndef CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_
6 #define CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_ 6 #define CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "chrome/test/base/in_process_browser_test.h" 11 #include "chrome/test/base/in_process_browser_test.h"
12 #include "content/public/browser/notification_observer.h" 12 #include "content/public/browser/notification_observer.h"
13 #include "content/public/browser/readback_types.h"
13 #include "net/test/embedded_test_server/embedded_test_server.h" 14 #include "net/test/embedded_test_server/embedded_test_server.h"
14 15
15 namespace base { 16 namespace base {
16 class CommandLine; 17 class CommandLine;
17 } 18 }
18 19
19 class SkBitmap; 20 class SkBitmap;
20 21
21 // This class is in its own separate file because it is used in both 22 // This class is in its own separate file because it is used in both
22 // browser_tests and interactive_ui_tests. 23 // browser_tests and interactive_ui_tests.
(...skipping 12 matching lines...) Expand all
35 36
36 int load_stop_notification_count() const { 37 int load_stop_notification_count() const {
37 return load_stop_notification_count_; 38 return load_stop_notification_count_;
38 } 39 }
39 40
40 void Load(); 41 void Load();
41 void WaitForResponse(); 42 void WaitForResponse();
42 bool VerifySnapshot(const std::string& expected_filename); 43 bool VerifySnapshot(const std::string& expected_filename);
43 44
44 private: 45 private:
45 void CopyFromBackingStoreCallback(bool success, const SkBitmap& bitmap); 46 void CopyFromBackingStoreCallback(const SkBitmap& bitmap,
47 content::ReadbackResponse response);
46 48
47 // content::NotificationObserver 49 // content::NotificationObserver
48 virtual void Observe(int type, 50 virtual void Observe(int type,
49 const content::NotificationSource& source, 51 const content::NotificationSource& source,
50 const content::NotificationDetails& details) override; 52 const content::NotificationDetails& details) override;
51 53
52 // InProcessBrowserTest 54 // InProcessBrowserTest
53 virtual void SetUpCommandLine(base::CommandLine* command_line) override; 55 virtual void SetUpCommandLine(base::CommandLine* command_line) override;
54 56
55 // True if the snapshot differed from the expected value. 57 // True if the snapshot differed from the expected value.
56 bool snapshot_different_; 58 bool snapshot_different_;
57 // Internal variable used to synchronize to the renderer. 59 // Internal variable used to synchronize to the renderer.
58 int next_dummy_search_value_; 60 int next_dummy_search_value_;
59 // The filename of the bitmap to compare the snapshot to. 61 // The filename of the bitmap to compare the snapshot to.
60 std::string expected_filename_; 62 std::string expected_filename_;
61 // If the snapshot is different, holds the location where it's saved. 63 // If the snapshot is different, holds the location where it's saved.
62 base::FilePath snapshot_filename_; 64 base::FilePath snapshot_filename_;
63 // How many times we've seen chrome::LOAD_STOP. 65 // How many times we've seen chrome::LOAD_STOP.
64 int load_stop_notification_count_; 66 int load_stop_notification_count_;
65 67
66 net::test_server::EmbeddedTestServer pdf_test_server_; 68 net::test_server::EmbeddedTestServer pdf_test_server_;
67 69
68 DISALLOW_COPY_AND_ASSIGN(PDFBrowserTest); 70 DISALLOW_COPY_AND_ASSIGN(PDFBrowserTest);
69 }; 71 };
70 72
71 #endif // CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_ 73 #endif // CHROME_BROWSER_UI_PDF_PDF_BROWSERTEST_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698