Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 59343002: drive: Simplify DownloadOperation by using ResourceEntry::local_id (Closed)

Created:
7 years, 1 month ago by hashimoto
Modified:
7 years, 1 month ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Simplify DownloadOperation by using ResourceEntry::local_id BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M chrome/browser/chromeos/drive/file_system/download_operation.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 9 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
7 years, 1 month ago (2013-11-05 08:46:05 UTC) #1
kinaba
lgtm. nice cleanup!
7 years, 1 month ago (2013-11-05 09:08:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/59343002/1
7 years, 1 month ago (2013-11-06 10:45:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94814
7 years, 1 month ago (2013-11-06 14:16:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/59343002/1
7 years, 1 month ago (2013-11-07 02:44:39 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:43:00 UTC) #6
Message was sent while issue was closed.
Change committed as 233510

Powered by Google App Engine
This is Rietveld 408576698