Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 593423002: Revert of DatabaseBackend should not post a task to an already terminated database thread (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 3 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of DatabaseBackend should not post a task to an already terminated database thread (patchset #4 id:60001 of https://codereview.chromium.org/596083005/) Reason for revert: This causes a lot of database layout test failures on the buildbots. Reverting. Original issue's description: > DatabaseBackend should not post a task to an already terminated database thread > > Currently some methods of DatabaseBackend post a task to a database thread without checking DatabaseThread::terminationRequested(). Consequently, the task can be posted to an already terminated database thread. > > This is problematic but by accident isn't currently causing any real issue (for some reason). This begins to cause an issue when I destruct DatabaseThread::m_thread promptly after the database thread processed a cleanup task (See https://codereview.chromium.org/589363002). > > This CL adds the necessary DatabaseThread::terminationRequested()s before DatabaseBackend posts a task to the database thread. > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182552 TBR=oilpan-reviews@chromium.org,tkent@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M Source/modules/webdatabase/Database.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTask.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/platform/TaskSynchronizer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/platform/TaskSynchronizer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
Created Revert of DatabaseBackend should not post a task to an already terminated database thread
6 years, 3 months ago (2014-09-24 06:42:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593423002/1
6 years, 3 months ago (2014-09-24 06:43:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182564
6 years, 3 months ago (2014-09-24 06:44:08 UTC) #3
haraken
6 years, 3 months ago (2014-09-24 07:04:06 UTC) #4
Message was sent while issue was closed.
LGTM, thanks for the revert.

Though I doubly-confirmed that the CL passed the test (and it actually passed
the commit queue)... Let me investigate.

Powered by Google App Engine
This is Rietveld 408576698