runtime/vm/assembler_arm_test.cc - Issue 593363003: Expands the use of Immediate and Operand wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 593363003: Expands the use of Immediate and Operand wrappers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm_test.cc

===================================================================

--- runtime/vm/assembler_arm_test.cc (revision 40678)

+++ runtime/vm/assembler_arm_test.cc (working copy)

@@ -900,7 +900,7 @@

__ clz(R1, R0);

__ cmp(R1, Operand(0));

__ b(&error, NE);

- __ Lsr(R0, R0, 3);

+ __ Lsr(R0, R0, Operand(3));

__ clz(R1, R0);

__ cmp(R1, Operand(3));

__ b(&error, NE);

@@ -979,8 +979,8 @@

Label skip;

__ mov(R0, Operand(1));

- __ Lsl(R0, R0, 31);

- __ Lsr(R0, R0, 31);

+ __ Lsl(R0, R0, Operand(31));

+ __ Lsr(R0, R0, Operand(31));

__ bx(LR);

}

@@ -996,8 +996,8 @@

Label skip;

__ mov(R0, Operand(1));

- __ Lsl(R0, R0, 31);

- __ Asr(R0, R0, 31);

+ __ Lsl(R0, R0, Operand(31));

+ __ Asr(R0, R0, Operand(31));

__ bx(LR);

}

« runtime/vm/assembler_arm.h ('K') | « runtime/vm/assembler_arm64_test.cc ('k') | runtime/vm/assembler_ia32.h » ('j') | runtime/vm/assembler_ia32.h » ('J')