The metro_driver should not block the UI thread while waiting for the Chrome browser IPC channel to…

win8/metro_driver/chrome_app_view_ash.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WIN8_METRO_DRIVER_CHROME_APP_VIEW_ASH_H_
 #define WIN8_METRO_DRIVER_CHROME_APP_VIEW_ASH_H_
 
 #include <windows.applicationmodel.core.h>
 #include <windows.ui.core.h>
 #include <windows.ui.input.h>
 #include <windows.ui.viewmanagement.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string16.h"
+#include "base/threading/thread.h"
 #include "ui/events/event_constants.h"
 #include "win8/metro_driver/direct3d_helper.h"
 #include "win8/metro_driver/ime/ime_popup_observer.h"
 #include "win8/metro_driver/ime/input_source_observer.h"
 #include "win8/metro_driver/ime/text_service_delegate.h"
 
 namespace base {
 class FilePath;
 }
 
@@ skipping 163 matching lines @@
                                  winui::Input::IEdgeGestureEventArgs* args);
 
   // Tasks posted to the UI thread to initiate the search/url navigation
   // requests.
   void OnSearchRequest(const base::string16& search_string);
   void OnNavigateToUrl(const base::string16& url);
 
   HRESULT OnSizeChanged(winui::Core::ICoreWindow* sender,
                         winui::Core::IWindowSizeChangedEventArgs* args);
 
+  // This function waits for the Chrome browser channel to be initialized.
+  // It then goes ahead and starts up the viewer in Chrome OS mode.
+  static void CALLBACK StartChromeOSMode(HWND core_window,
+                                         UINT message,
+                                         UINT_PTR timer_id,
+                                         DWORD time);
+
   mswr::ComPtr<winui::Core::ICoreWindow> window_;
   mswr::ComPtr<winapp::Core::ICoreApplicationView> view_;
   EventRegistrationToken activated_token_;
   EventRegistrationToken pointermoved_token_;
   EventRegistrationToken pointerpressed_token_;
   EventRegistrationToken pointerreleased_token_;
   EventRegistrationToken wheel_token_;
   EventRegistrationToken keydown_token_;
   EventRegistrationToken keyup_token_;
   EventRegistrationToken character_received_token_;
   EventRegistrationToken accel_keydown_token_;
   EventRegistrationToken accel_keyup_token_;
   EventRegistrationToken window_activated_token_;
   EventRegistrationToken sizechange_token_;
   EventRegistrationToken edgeevent_token_;
 
   // Keep state about which button is currently down, if any, as PointerMoved
   // events do not contain that state, but Ash's MouseEvents need it. Value is
   // as a bitmask of ui::EventFlags.
   uint32 mouse_down_flags_;
 
   // Set the D3D swap chain and nothing else.
   metro_driver::Direct3DHelper direct3d_helper_;
 
   // The channel to Chrome, in particular to the MetroViewerProcessHost.
-  IPC::ChannelProxy* ui_channel_;
+  scoped_ptr<IPC::ChannelProxy> ui_channel_;
 
   // The actual window behind the view surface.
   HWND core_window_hwnd_;
 
   // UI message loop to allow message passing into this thread.
   base::MessageLoopForUI ui_loop_;
 
   // For IME support.
   scoped_ptr<metro_driver::InputSource> input_source_;
   scoped_ptr<metro_driver::TextService> text_service_;
 
   // The metro device scale factor as reported by the winrt interfaces.
   float metro_dpi_scale_;
   // The win32 dpi scale which is queried via GetDeviceCaps. Please refer to
   // ui/gfx/win/dpi.cc for more information.
   float win32_dpi_scale_;
 
   // The cursor set by the chroem browser process.
   HCURSOR last_cursor_;
+
+  // The IPC channel IO thread.
+  scoped_ptr<base::Thread> io_thread_;

[scottmg, 2014/09/24 02:40:32]

maybe move this above the ui_channel_ since it's supposed to outlive that. (i
know it's manually reset)

[ananta, 2014/09/24 18:22:33]

Done.

 };
 
 #endif  // WIN8_METRO_DRIVER_CHROME_APP_VIEW_ASH_H_