Implement basic mocks for testing.

Implement basic mocks for testing.

These may need to be made more elaborate once we start using them in
browser tests, but I've verified that they can be used to mock a basic
connection with resize support.

Committed: https://crrev.com/8e0666d30aeb18d0672ca7ab6a9867ee97da159b
Cr-Commit-Position: refs/heads/master@{#296624}

[Jamie, 2014-09-23 23:53:54]

jamiewalch@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Jamie, 2014-09-23 23:53:55]

ptal

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_client_plugin.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:58:
window.setTimeout(onDone.bind(null, true), 0);
All callbacks are asynchronous.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_session_connector.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:98:
this.onConnected_(clientSession);
Part of the API contract for SessionConnector is that it handles state changes
up to and including CONNECTED, so this mock contains more boilerplate than I
would like (can't just call onConnected).

[Sergey Ulanov, 2014-09-24 01:26:59]

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_client_plugin.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
year

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:7: * Interface abstracting
the ClientPlugin functionality.
update the comment

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:18: * @extends
{remoting.ClientPlugin}
Should this be @implements instead of @extends?

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_session_connector.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
year

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:90: var clientSession =
new remoting.ClientSession(
Why do you  need to create real ClientSession here? Doesn't it create real
plugin?

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:108: 
nit:remove extra empty lines

[Jamie, 2014-09-24 17:03:46]

ptal

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_client_plugin.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2014/09/24 01:26:59, Sergey Ulanov wrote:
> year

Done.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:7: * Interface abstracting
the ClientPlugin functionality.
On 2014/09/24 01:26:58, Sergey Ulanov wrote:
> update the comment

Done.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_client_plugin.js:18: * @extends
{remoting.ClientPlugin}
On 2014/09/24 01:26:59, Sergey Ulanov wrote:
> Should this be @implements instead of @extends?

Done.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
File remoting/webapp/browser_test/mock_session_connector.js (right):

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
On 2014/09/24 01:26:59, Sergey Ulanov wrote:
> year

Done.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:90: var clientSession =
new remoting.ClientSession(
On 2014/09/24 01:26:59, Sergey Ulanov wrote:
> Why do you  need to create real ClientSession here? Doesn't it create real
> plugin?

ClientSession contains most of the application logic we want to test
(bump-scrolling, etc.) so we need the real thing here. It creates a plugin
instance via ClientPlugin.factory, so it can be overridden by setting a mock
factory.

https://codereview.chromium.org/593313003/diff/40001/remoting/webapp/browser_...
remoting/webapp/browser_test/mock_session_connector.js:108: 
On 2014/09/24 01:26:59, Sergey Ulanov wrote:
> nit:remove extra empty lines

I've removed one of them. I prefer to leave two blank lines because this is a
separate class definition.

[Sergey Ulanov, 2014-09-25 00:31:05]

lgtm

[Jamie, 2014-09-25 00:46:02]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-09-25 00:46:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593313003/60001

[commit-bot: I haz the power, 2014-09-25 02:10:17]

Committed patchset #4 (id:60001) as 0d70c0a78ec7cc66f926f7025ffaafa3a54c3a33

[commit-bot: I haz the power, 2014-09-25 02:10:59]

Patchset 4 (id:??) landed as
https://crrev.com/8e0666d30aeb18d0672ca7ab6a9867ee97da159b
Cr-Commit-Position: refs/heads/master@{#296624}