Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 593283002: Update console log to reflect new speech queue features. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@exiting_dialog
Project:
chromium
Visibility:
Public.

Description

Update console log to reflect new speech queue features. Without this, it's hard to know what will be spoken due to the new category flush queueing mode. BUG=none Committed: https://crrev.com/0c69278f817f533d234c9b171cff61eea5d3b074 Cr-Commit-Position: refs/heads/master@{#296856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/console_tts.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
6 years, 3 months ago (2014-09-23 19:59:29 UTC) #2
David Tseng
lgtm
6 years, 2 months ago (2014-09-25 22:52:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593283002/1
6 years, 2 months ago (2014-09-25 22:55:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4520929177373fea5afbbc106f1d2aa3937be87c
6 years, 2 months ago (2014-09-26 02:06:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 02:07:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c69278f817f533d234c9b171cff61eea5d3b074
Cr-Commit-Position: refs/heads/master@{#296856}

Powered by Google App Engine
This is Rietveld 408576698