Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

Issue 593273002: Excludes settings which uses Ash from Athena. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
index 498673fca0ff17b47f73ff5ce8da2092ea1fec0f..ac46347714db012cde7df2717749c1f4bf8a857a 100644
--- a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
@@ -156,7 +156,12 @@ void KeyboardHandler::RegisterMessages() {
}
void KeyboardHandler::HandleShowKeyboardShortcuts(const base::ListValue* args) {
+#if defined(USE_ATHENA)
+ // Athena doesn't have ash::Shell and its new_window_delegate so keyboard
+ // shortcut overlays are not supported.
+ // TODO(mukai): re-enable this.
ash::Shell::GetInstance()->new_window_delegate()->ShowKeyboardOverlay();
+#endif
}
} // namespace options
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698