Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/auto_bisect/builder.py

Issue 593253002: Follow-up to crrev.com/583793002 -- check if goma_dir is None. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/builder.py
diff --git a/tools/auto_bisect/builder.py b/tools/auto_bisect/builder.py
index 6b530f78ac133576640cda54f9462cbcb8404206..a2f779776f78b01b02bd611623ee979b060ba05b 100644
--- a/tools/auto_bisect/builder.py
+++ b/tools/auto_bisect/builder.py
@@ -39,9 +39,11 @@ class Builder(object):
raise RuntimeError(
'Path to visual studio could not be determined.')
else:
+ # Need to re-escape goma dir, see crbug.com/394990.
+ if opts.goma_dir:
+ opts.goma_dir = opts.goma_dir.encode('string_escape')
SetBuildSystemDefault(opts.build_preference, opts.use_goma,
- # Need to re-escape goma dir, see crbug.com/394990
- opts.goma_dir.encode('string_escape'))
+ opts.goma_dir)
else:
if not opts.build_preference:
if 'ninja' in os.getenv('GYP_GENERATORS', default=''):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698