Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 593253002: Follow-up to crrev.com/583793002 -- check if goma_dir is None. (Closed)

Created:
6 years, 3 months ago by qyearsley
Modified:
6 years, 3 months ago
Reviewers:
sullivan, prasadv
CC:
chromium-reviews, prasadv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Follow-up to crrev.com/583793002 -- check if goma_dir is None. BUG=394990 Committed: https://crrev.com/4eca61356cefcee6da31ef56bfd570442abde75e Cr-Commit-Position: refs/heads/master@{#296312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/auto_bisect/builder.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
Looks like goma_dir might sometimes be None. http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/191/steps/Running%20Bisection/logs/stdio
6 years, 3 months ago (2014-09-23 19:17:39 UTC) #2
prasadv
lgtm
6 years, 3 months ago (2014-09-23 23:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593253002/1
6 years, 3 months ago (2014-09-23 23:08:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7ad04b8b8bd7b6e2a5dd8916f6333c86c65daf3f
6 years, 3 months ago (2014-09-24 00:18:49 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 00:19:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eca61356cefcee6da31ef56bfd570442abde75e
Cr-Commit-Position: refs/heads/master@{#296312}

Powered by Google App Engine
This is Rietveld 408576698