Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 593243003: Cleanup: Remove unused dependency on NaCl src/trusted/gio target (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused dependency on NaCl src/trusted/gio target ppapi/ no longer has any references to NaCl's "Gio" code. This cleanup will allow the Gyp file to be removed from the NaCl side. BUG=none TEST=build Committed: https://crrev.com/51edc1f09281700703dd1c76ec4cfa0bc03b1e09 Cr-Commit-Position: refs/heads/master@{#296323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ppapi/native_client/src/trusted/plugin/plugin.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Mark Seaborn
6 years, 3 months ago (2014-09-23 23:09:10 UTC) #2
teravest
lgtm
6 years, 3 months ago (2014-09-23 23:11:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593243003/1
6 years, 3 months ago (2014-09-23 23:14:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17719)
6 years, 3 months ago (2014-09-23 23:59:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593243003/1
6 years, 3 months ago (2014-09-24 01:38:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as f103a19c044dbf932919a9b15f292d89ed5bd3c3
6 years, 3 months ago (2014-09-24 01:43:11 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 01:43:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51edc1f09281700703dd1c76ec4cfa0bc03b1e09
Cr-Commit-Position: refs/heads/master@{#296323}

Powered by Google App Engine
This is Rietveld 408576698