Profile_Metrics integration with Keystone

chrome/browser/profiles/profile_metrics.cc

Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index 0804fd88b8de1a4f9306faa0cec4e890e09404e1..45d2c08d1268b25e629b970eea833baa839c7f0d 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -38,12 +38,6 @@ ProfileMetrics::ProfileType GetProfileType(
   return metric;
 }
 
-void UpdateReportedOSProfileStatistics(int active, int signedin) {
-#if defined(OS_WIN)
-  GoogleUpdateSettings::UpdateProfileCounts(active, signedin);
-#endif
-}
-
 void LogLockedProfileInformation(ProfileManager* manager) {
   const ProfileInfoCache& info_cache = manager->GetProfileInfoCache();
   size_t number_of_profiles = info_cache.GetNumberOfProfiles();
@@ -157,10 +151,20 @@ void ProfileMetrics::UpdateReportedProfilesStatistics(ProfileManager* manager) {
           (int)((float)(counts.signedin * limited_total)
           / counts.total + 0.5);
     }
+#if defined(OS_WIN) || defined(OS_MACOSX)
     UpdateReportedOSProfileStatistics(limited_total, limited_signedin);
+#endif
   }
 }
 
+// The MACOSX implementation of this function is in profile_metrics_mac.mm.
+#if defined(OS_WIN)
+void ProfileMetrics::UpdateReportedOSProfileStatistics(

[bcwhite, 2014/09/23 20:32:58]

Any particular reason you moved the block down here from its original position? 
Makes the diff less obvious.

[Mike Lerman, 2014/09/26 19:52:30]

The method was previously in the anonymous namespace. The method is now a static
member of the class, so was moved down to the class methods.

+    int active, int signedin) {
+  GoogleUpdateSettings::UpdateProfileCounts(active, signedin);
+}
+#endif
+
 void ProfileMetrics::LogNumberOfProfiles(ProfileManager* manager) {
   ProfileCounts counts;
   bool success = CountProfileInformation(manager, &counts);
@@ -180,7 +184,10 @@ void ProfileMetrics::LogNumberOfProfiles(ProfileManager* manager) {
                              counts.gaia_icon);
 
     LogLockedProfileInformation(manager);
+
+#if defined(OS_WIN) || defined(OS_MACOSX)
     UpdateReportedOSProfileStatistics(counts.total, counts.signedin);
+#endif
   }
 }