Profile_Metrics integration with Keystone

chrome/browser/mac/keystone_glue.h

Index: chrome/browser/mac/keystone_glue.h
diff --git a/chrome/browser/mac/keystone_glue.h b/chrome/browser/mac/keystone_glue.h
index 5c21c369e80294ede452810b37885491d48c7f79..b5515c7c018b970eb36fab384d25eabd37ddacb0 100644
--- a/chrome/browser/mac/keystone_glue.h
+++ b/chrome/browser/mac/keystone_glue.h
@@ -72,6 +72,8 @@ enum BrandFileType {
 // Keystone.
 
 @class KSRegistration;
+@class KSReportingAttriburte;

[Mark Mentovai, 2014/10/06 18:35:13]

This header doesn’t make use of KSReportingAttribute or
KSUnsignedReportingAttribute, so these declarations don’t belong here.

KSReportingAttribute is misspelled as KSReportingAttriburte here, anyway.

[Mike Lerman, 2014/10/09 20:41:01]

Done. In a previous local incarnation I had direct member objects.

+@class KSUnsignedReportingAttribute;
 
 @interface KeystoneGlue : NSObject {
  @protected
@@ -101,6 +103,10 @@ enum BrandFileType {
 
   // YES if an update was ever successfully installed by -installUpdate.
   BOOL updateSuccessfullyInstalled_;
+
+  // Profile count information.
+  size_t numProfiles_;
+  size_t numSignedInProfiles_;
 }
 
 // Return the default Keystone Glue object.
@@ -172,6 +178,10 @@ enum BrandFileType {
 // at the installed copy.
 - (void)setAppPath:(NSString*)appPath;
 
+// Sets the total number of profiles and the number of signed in profiles.
+- (void)updateProfileCountsWithNumProfiles:(size_t)numProfiles

[Mark Mentovai, 2014/10/06 18:35:13]

The caller’s interface uses int and Keystone’s interface uses uint32_t. You’re
now adding a third distinct type, size_t.

The most prudent thing to do when adapting the two dissimilar types (int and
uint32_t) would be to check that the source value is in range for the
destination type. base/numerics/safe_conversions.h can help.

The least prudent thing to do is to introduce a third type and not have any
range checking on the values at all.

[Mike Lerman, 2014/10/09 20:41:01]

Ah, indeed. Used to using size_t in the chromium code. I'll change this to the
uint32_t and do the conversion in profile_metrics_mac.mm.

+                       numSignedInProfiles:(size_t)numSignedInProfiles;
+
 @end  // @interface KeystoneGlue
 
 @interface KeystoneGlue(ExposedForTesting)