chrome/browser/profiles/profile_metrics_mac.mm - Issue 593243002: Profile_Metrics integration with Keystone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profiles/profile_metrics_mac.mm

Issue 593243002: Profile_Metrics integration with Keystone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Borisv comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
	Mark Mentovai 2014/10/02 16:07:23 No (c) in new files. No (c) in new files. Mike Lerman 2014/10/09 20:41:01 Done. Show quoted text On 2014/10/02 16:07:23, Mark Mentovai wrote: > No (c) in new files. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/profiles/profile_metrics.h"

	6

	7 #include "chrome/browser/mac/keystone_glue.h"

	8

	9 #if defined(OS_MACOSX)
	Mark Mentovai 2014/10/02 16:07:23 Not necessary. _mac.mm files will only be built on Not necessary. _mac.mm files will only be built on Mac. Mike Lerman 2014/10/06 16:49:08 They don't come on iOS as well? Show quoted text On 2014/10/02 16:07:23, Mark Mentovai wrote: > Not necessary. _mac.mm files will only be built on Mac. They don't come on iOS as well? Mark Mentovai 2014/10/06 18:35:13 Mike Lerman wrote: Mike Lerman wrote: Show quoted text > On 2014/10/02 16:07:23, Mark Mentovai wrote: > > Not necessary. _mac.mm files will only be built on Mac. > > They don't come on iOS as well? _mac.mm files are built on Mac only, not on iOS. See build/filename_rules.gypi. Mike Lerman 2014/10/09 20:41:01 Cool, good to know. Done. Show quoted text On 2014/10/06 18:35:13, Mark Mentovai wrote: > Mike Lerman wrote: > > On 2014/10/02 16:07:23, Mark Mentovai wrote: > > > Not necessary. _mac.mm files will only be built on Mac. > > > > They don't come on iOS as well? > > _mac.mm files are built on Mac only, not on iOS. See build/filename_rules.gypi. Cool, good to know. Done.
	10 void ProfileMetrics::UpdateReportedOSProfileStatistics(

	11 int active, int signedin) {

	12 [[KeystoneGlue defaultKeystoneGlue]

	13 updateProfileCountsWithNumProfiles:active

	14 numSignedInProfiles:signedin];

	15 }

	16 #endif

OLD	NEW

« chrome/browser/mac/keystone_reporting_attribute.h ('K') | « chrome/browser/profiles/profile_metrics.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »