Profile_Metrics integration with Keystone

chrome/browser/mac/keystone_glue.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_
 #define CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_
 
 #include "base/strings/string16.h"
 
 #if defined(__OBJC__)
@@ skipping 83 matching lines @@
   // The authorization object, when it needs to persist because it's being
   // carried across threads.
   base::mac::ScopedAuthorizationRef authorization_;
 
   // YES if a synchronous promotion operation is in progress (promotion during
   // installation).
   BOOL synchronousPromotion_;
 
   // YES if an update was ever successfully installed by -installUpdate.
   BOOL updateSuccessfullyInstalled_;
+
+  // Profile count information.
+  uint32_t numProfiles_;
+  uint32_t numSignedInProfiles_;
 }
 
 // Return the default Keystone Glue object.
 + (id)defaultKeystoneGlue;
 
 // Load KeystoneRegistration.framework if present, call into it to register
 // with Keystone, and set up periodic activity pings.
 - (void)registerWithKeystone;
 
 // -checkForUpdate launches a check for updates, and -installUpdate begins
@@ skipping 51 matching lines @@
                            synchronous:(BOOL)synchronous;
 
 // Requests authorization and calls -promoteTicketWithAuthorization: in
 // asynchronous mode.
 - (void)promoteTicket;
 
 // Sets a new value for appPath.  Used during installation to point a ticket
 // at the installed copy.
 - (void)setAppPath:(NSString*)appPath;
 
+// Sets the total number of profiles and the number of signed in profiles.
+- (void)updateProfileCountsWithNumProfiles:(uint32_t)numProfiles

[Mark Mentovai, 2015/02/20 21:54:18]

I don’t think you need “num” in any of these, same in the .mm file. It’s obvious
that a count is going to be a number.

[Mike Lerman, 2015/02/23 16:12:11]

Done - though the class' member variables (numProfiles_ and
numSignedInProfiles_) should probably keep the prefix since they're not
explicitly parameters to a method called "count" - their meaning needs to stand
alone a bit better.

+                       numSignedInProfiles:(uint32_t)numSignedInProfiles;
+
 @end  // @interface KeystoneGlue
 
 @interface KeystoneGlue(ExposedForTesting)
 
 // Load any params we need for configuring Keystone.
 - (void)loadParameters;
 
 // Load the Keystone registration object.
 // Return NO on failure.
 - (BOOL)loadKeystoneRegistration;
@@ skipping 20 matching lines @@
 
 // True if Keystone is enabled.
 bool KeystoneEnabled();
 
 // The version of the application currently installed on disk.
 base::string16 CurrentlyInstalledVersion();
 
 }  // namespace keystone_glue
 
 #endif  // CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_