Modified GPU command signature hash to use a binary representation.

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bits.h"
@@ skipping 202 matching lines @@
   DCHECK(feature_info);
   DCHECK(signature);
   DCHECK_GE(level, 0);
   size_t face_index = GLES2Util::GLTargetToFaceIndex(target);
   DCHECK_LT(static_cast<size_t>(face_index),
             level_infos_.size());
   DCHECK_LT(static_cast<size_t>(level),
             level_infos_[face_index].size());
   const Texture::LevelInfo& info =
       level_infos_[face_index][level];
-  *signature += base::StringPrintf(
-      "|Texture|target=%04x|level=%d|internal_format=%04x"
-      "|width=%d|height=%d|depth=%d|border=%d|format=%04x|type=%04x"
-      "|image=%d|canrender=%d|canrenderto=%d|npot_=%d"
-      "|min_filter=%04x|mag_filter=%04x|wrap_s=%04x|wrap_t=%04x"
-      "|usage=%04x",
-      target, level, info.internal_format,
-      info.width, info.height, info.depth, info.border,
-      info.format, info.type, info.image.get() != NULL,
-      CanRender(feature_info), CanRenderTo(), npot_,
-      min_filter_, mag_filter_, wrap_s_, wrap_t_,
-      usage_);
+
+  signature->append("|Texture|");
+  signature->append(reinterpret_cast<const char*>(&target), sizeof(target));
+  signature->append(reinterpret_cast<const char*>(&level), sizeof(level));
+  signature->append(reinterpret_cast<const char*>(&info.internal_format),
+                    sizeof(info.internal_format));
+  signature->append(reinterpret_cast<const char*>(&info.width),
+                    sizeof(info.width));
+  signature->append(reinterpret_cast<const char*>(&info.height),
+                    sizeof(info.height));
+  signature->append(reinterpret_cast<const char*>(&info.depth),
+                    sizeof(info.depth));
+  signature->append(reinterpret_cast<const char*>(&info.border),
+                    sizeof(info.border));
+  signature->append(reinterpret_cast<const char*>(&info.format),
+                    sizeof(info.format));
+  signature->append(reinterpret_cast<const char*>(&info.type),
+                    sizeof(info.type));
+
+  const bool has_image = info.image.get() != NULL;
+  signature->append(reinterpret_cast<const char*>(&has_image),
+                    sizeof(has_image));
+
+  const bool can_render = CanRender(feature_info);
+  signature->append(reinterpret_cast<const char*>(&can_render),
+                    sizeof(can_render));
+
+  const bool can_render_to = CanRenderTo();
+  signature->append(reinterpret_cast<const char*>(&can_render_to),
+                    sizeof(can_render_to));
+
+  signature->append(reinterpret_cast<const char*>(&npot_),
+                    sizeof(npot_));
+  signature->append(reinterpret_cast<const char*>(&min_filter_),
+                    sizeof(min_filter_));
+  signature->append(reinterpret_cast<const char*>(&wrap_s_),
+                    sizeof(wrap_s_));
+  signature->append(reinterpret_cast<const char*>(&wrap_t_),
+                    sizeof(wrap_t_));
+  signature->append(reinterpret_cast<const char*>(&usage_),
+                    sizeof(usage_));

[vmiura, 2014/09/23 20:26:47]

As with Renderbuffer, would these be better if packed into structs that can be
appended?

 }
 
 void Texture::SetMailboxManager(MailboxManager* mailbox_manager) {
   DCHECK(!mailbox_manager_ || mailbox_manager_ == mailbox_manager);
   mailbox_manager_ = mailbox_manager;
 }
 
 bool Texture::MarkMipmapsGenerated(
     const FeatureInfo* feature_info) {
   if (!CanGenerateMipmaps(feature_info)) {
@@ skipping 1298 matching lines @@
 }
 
 ScopedTextureUploadTimer::~ScopedTextureUploadTimer() {
   texture_state_->texture_upload_count++;
   texture_state_->total_texture_upload_time +=
       base::TimeTicks::HighResNow() - begin_time_;
 }
 
 }  // namespace gles2
 }  // namespace gpu